Skip to content

[CI] Add support for Black formatting#21281

Merged
richardliaw merged 5 commits intoray-project:masterfrom
bveeramani:add-black
Jan 3, 2022
Merged

[CI] Add support for Black formatting#21281
richardliaw merged 5 commits intoray-project:masterfrom
bveeramani:add-black

Conversation

@bveeramani
Copy link
Copy Markdown
Member

@bveeramani bveeramani commented Dec 28, 2021

Why are these changes needed?

These changes are needed so that we can format our code with Black instead of YAPF.

For more information about the motivation behind the changes, see #21311 and #21312.

Related issue number

Closes #21312. Also see #21311.

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@bveeramani bveeramani marked this pull request as draft December 28, 2021 09:48
@bveeramani bveeramani closed this Dec 28, 2021
@bveeramani bveeramani reopened this Jan 1, 2022
@bveeramani bveeramani changed the title [WIP] Add support for Black formatting [CI] Add support for Black formatting Jan 1, 2022
@bveeramani bveeramani marked this pull request as ready for review January 1, 2022 00:28
Copy link
Copy Markdown
Contributor

@pcmoritz pcmoritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, it works for me locally :)

E121
E123
E126
E203
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit to add a comment somewhere about why e203 is excluded

@richardliaw richardliaw merged commit 43a9e95 into ray-project:master Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] Update format.sh to support the Black code style

4 participants