Skip to content

[Test] Add small scale threaded actor test#19720

Closed
rkooo567 wants to merge 2 commits intoray-project:masterfrom
rkooo567:add-small-scale-threaded-actor-test
Closed

[Test] Add small scale threaded actor test#19720
rkooo567 wants to merge 2 commits intoray-project:masterfrom
rkooo567:add-small-scale-threaded-actor-test

Conversation

@rkooo567
Copy link
Copy Markdown
Contributor

@rkooo567 rkooo567 commented Oct 25, 2021 •
edited
Loading

Why are these changes needed?

Port test_dead_actor with 10 max_concurrency to the CI for a sanity check. (this is not the repro test)

This can pretty easily reproduce this error msg;

2021-10-25 15:07:16,796	WARNING worker.py:1218 -- The actor or task with ID ffffffffffffffff1ab08acbe91bab6c32ecde9901000000 cannot be scheduled right now. You can ignore this message if this Ray cluster is expected to auto-scale or if you specified a runtime_env for this actor or task, which may take time to install.  Otherwise, this is likely due to all cluster resources being claimed by actors. To resolve the issue, consider creating fewer actors or increasing the resources available to this Ray cluster.
Required resources for this actor or task: {CPU: 1.000000}
Available resources on this node: {2.000000/2.000000 CPU, 432533200.000000 GiB/432533200.000000 GiB memory, 7680000.000000 GiB/7680000.000000 GiB object_store_memory, 1.000000/1.000000 node:127.0.0.1}
In total there are 0 pending tasks and 4 pending actors on this node.

I will make an issue to investigate this after the PR is merged

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@rkooo567
Copy link
Copy Markdown
Contributor Author

rkooo567 commented Oct 26, 2021

@scv119 Btw, I think I can grab the stderr and make sure there's no keyword SIGBART and SIGSEGV. It seems to be a pretty good regression test to check shutdown error

@rkooo567 rkooo567 mentioned this pull request Oct 26, 2021
Merged
6 tasks
@rkooo567
Copy link
Copy Markdown
Contributor Author

rkooo567 commented Oct 26, 2021

will be replaced by #19746

@rkooo567 rkooo567 closed this Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scv119 scv119 scv119 approved these changes

Assignees

@scv119 scv119

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rkooo567 @scv119