[Hotfix] Revert "[Lint] run clang-tidy in scripts/format.h, update clang-t…#19119
Merged
ericl merged 1 commit intoray-project:masterfrom Oct 5, 2021
Merged
[Hotfix] Revert "[Lint] run clang-tidy in scripts/format.h, update clang-t…#19119ericl merged 1 commit intoray-project:masterfrom
clang-tidy in scripts/format.h, update clang-t…#19119ericl merged 1 commit intoray-project:masterfrom
Conversation
…idy rules (ray-project#19055)" This reverts commit 5d9e3a0.
clang-tidy in scripts/format.h, update clang-t…clang-tidy in scripts/format.h, update clang-t…
clarkzinzow
approved these changes
Oct 5, 2021
mwtian
approved these changes
Oct 5, 2021
Member
|
Which step is taking a long time, is it clang-tidy or clang-format? |
Contributor
Author
|
As I understand it, it's slow because the PR broke the base-diffing algorithm. Looking at the original PR, I don't think we should have made such a huge change to such a delicate (and not well tested) script. |
richardliaw
approved these changes
Oct 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…idy rules (#19055)"
This reverts commit 5d9e3a0.
Why are these changes needed?
After this PR, running scripts/format.sh is very slow. I think this is breaking the incremental format logic which only lints changed files.