Fix false positive error message from autoscaler events#18981
Merged
ericl merged 2 commits intoray-project:masterfrom Sep 29, 2021
Merged
Fix false positive error message from autoscaler events#18981ericl merged 2 commits intoray-project:masterfrom
ericl merged 2 commits intoray-project:masterfrom
Conversation
richardliaw
approved these changes
Sep 29, 2021
Contributor
richardliaw
left a comment
There was a problem hiding this comment.
nice! i'm going to rubber stamp
DmitriGekhtman
approved these changes
Sep 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The previous PR incorrectly filtered out node: custom resources from the "manual cluster" mode, which leads to occasional false positive warnings. This PR removes this bad check and adds a test.
I verified the test fails before this fix.
Closes #18979