[DataFrame] Changing the _default_index fn to a remote function#1617
Merged
devin-petersohn merged 1 commit intoray-project:masterfrom Feb 27, 2018
Merged
[DataFrame] Changing the _default_index fn to a remote function#1617devin-petersohn merged 1 commit intoray-project:masterfrom
devin-petersohn merged 1 commit intoray-project:masterfrom
Conversation
|
Test PASSed. |
devin-petersohn
approved these changes
Feb 27, 2018
Member
devin-petersohn
left a comment
There was a problem hiding this comment.
Great optimization. Thanks @kunalgosar
Member
|
Passed the private-travis. OK to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Moving _default_index to a remote function speeds up creating a new DataFrame. Since _default_index will now return a futures object, the main thread is freed and returned to the user much quicker. This does not necessarily mean that the full computation has finished, but the main thread can continue running.
Updated Performance on Query against Pandas
Data: 76 MB of String Data
Machine: 2 Core Macbook
Partitions: 4
Pandas Benchmark:
%timeit pandas_df.query(query_func) # 172 msRay:
%timeit ray_df.query(query_func) # 15.2 ms