Skip to content

[Wheel] Turn off 3.9 build for macOS only#15006

Closed
simon-mo wants to merge 1 commit intoray-project:masterfrom
simon-mo:no-py39-macos
Closed

[Wheel] Turn off 3.9 build for macOS only#15006
simon-mo wants to merge 1 commit intoray-project:masterfrom
simon-mo:no-py39-macos

Conversation

@simon-mo
Copy link
Copy Markdown
Contributor

Why are these changes needed?

Wheels build for macOS is still broken. This attempt to fix it.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@rkooo567
Copy link
Copy Markdown
Contributor

Should we merge it rn?

@wuisawesome wuisawesome mentioned this pull request Mar 31, 2021
@tbabej
Copy link
Copy Markdown
Contributor

tbabej commented Apr 1, 2021

Will the build pipeline produce also new ray:nightly-py39 images after merging this, or is further action required for that?

@simon-mo
Copy link
Copy Markdown
Contributor Author

simon-mo commented Apr 1, 2021

We should make that happen. @ijrsvt any hint on how to add py39 imgs?

@ijrsvt
Copy link
Copy Markdown
Contributor

ijrsvt commented Apr 1, 2021

@simon-mo (@tbabej )
To start building py39 docker images we will need to make sure that linux Py39 wheels are being built. It will require some modification to build-docker-images.py (but that should be very minimal).

@wuisawesome
Copy link
Copy Markdown
Contributor

Doesn't look like wheel need this anymore (hehehe)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants