Skip to content

upgrade setproctitle dep#14538

Merged
simon-mo merged 1 commit intoray-project:masterfrom
acxz:upd-setproctitle
Mar 17, 2021
Merged

upgrade setproctitle dep#14538
simon-mo merged 1 commit intoray-project:masterfrom
acxz:upd-setproctitle

Conversation

@acxz
Copy link
Copy Markdown
Contributor

@acxz acxz commented Mar 8, 2021

Why are these changes needed?

For python 3.9, we need setproctitle at version 1.2.1 or higher. This PR updates the setproctitle dep.

Related issue number

#12613 (comment)

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Copy link
Copy Markdown
Contributor

@amogkam amogkam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only failing tests are known flaky ones so lgtm. Thanks a bunch for all your effort in getting the 3.9 wheels out @acxz!

@amogkam
Copy link
Copy Markdown
Contributor

amogkam commented Mar 17, 2021

cc @simon-mo if you also want to take a look at this and merge.

@simon-mo simon-mo merged commit 6e326cc into ray-project:master Mar 17, 2021
@acxz
Copy link
Copy Markdown
Contributor Author

acxz commented Mar 17, 2021

thx for having this merged in!

@acxz acxz deleted the upd-setproctitle branch March 17, 2021 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants