Fix deadlock in unhandled exception handler and re-merge (#3)#14192
Merged
ericl merged 3 commits intoray-project:masterfrom Feb 19, 2021
Merged
Fix deadlock in unhandled exception handler and re-merge (#3)#14192ericl merged 3 commits intoray-project:masterfrom
ericl merged 3 commits intoray-project:masterfrom
Conversation
…ing (ray-project#14138)" (ray-project#14180)" This reverts commit 66f93a3.
rkooo567
approved these changes
Feb 18, 2021
edoakes
approved these changes
Feb 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The last commit posts the unhandled exception handler onto the main event loop, avoiding the deadlock scenario where we call back into Python while holding a core worker lock.