[ray_client]: Client PlacementGroup hooks#14060
Closed
barakmich wants to merge 2 commits intoray-project:masterfrom
Closed
[ray_client]: Client PlacementGroup hooks#14060barakmich wants to merge 2 commits intoray-project:masterfrom
barakmich wants to merge 2 commits intoray-project:masterfrom
Conversation
Change-Id: I1af5219a2aa057603cd0eca534dda0f1c9ef067b
Contributor
|
Btw, are we testing this somewhere? (not so familiar with client code base) |
Contributor
|
Seems to be breaking placement group tests (and we should add some client tests). |
Contributor
|
Closing for now |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Way better than #13310 -- no extra client-classes, simply control placement groups by sending the commands as tasks
Related issue number
Closes #13147
Checks
scripts/format.shto lint the changes in this PR.