[Metrics] Make DeltaProducer thread detached#13565
Closed
simon-mo wants to merge 3 commits intoray-project:masterfrom
Closed
[Metrics] Make DeltaProducer thread detached#13565simon-mo wants to merge 3 commits intoray-project:masterfrom
simon-mo wants to merge 3 commits intoray-project:masterfrom
Conversation
6 tasks
Contributor
|
I have some questions;
Also @ashione Please take a look! |
Member
In my experience, we'd better to fix the above issues rather than just skip shutdown or make harvest thread as a detached thread. |
Member
|
Please hold on. I'll try to figure out why opencensus thread crashed before next weekend. |
Contributor
Author
|
@ashione any update? |
Contributor
I have encountered the same problem and am looking for a solution. We'd better restart the thread. |
Member
Collaborator
|
ping @simon-mo |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR fixes a problem with Ray stats not being correctly cleaned up upon
ray.shutdown(). This PR resets the global variableshandlers_andviews_inStatsExporterupon shutdown. ForDeltaProducer, shutdown is skipped because the global singleton thread cannot be restarted afterray.shutdown()followed byray.init().Related issue number
Closes #13532.
Checks
scripts/format.shto lint the changes in this PR.