Skip to content

[CI] Fix windows build#12415

Merged
simon-mo merged 11 commits intoray-project:masterfrom
amogkam:windows-fix
Nov 26, 2020
Merged

[CI] Fix windows build#12415
simon-mo merged 11 commits intoray-project:masterfrom
amogkam:windows-fix

Conversation

@amogkam
Copy link
Copy Markdown
Contributor

@amogkam amogkam commented Nov 25, 2020

Our windows build was previously failing with

src/spt_setup.c(23): warning C4273: '__p__environ': inconsistent dll linkage
  C:\Program Files (x86)\Windows Kits\10\include\10.0.19041.0\ucrt\stdlib.h(1158): note: see previous definition of '__p__environ'
  src/spt_setup.c(454): error C2099: initializer is not a constant
  error: command 'C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\Enterprise\\VC\\Tools\\MSVC\\14.28.29333\\bin\\HostX86\\x64\\cl.exe' failed with exit status 2
  ----------------------------------------
  ERROR: Failed building wheel for setproctitle
ERROR: Could not build wheels for setproctitle which use PEP 517 and cannot be installed directly
Error: Process completed with exit code 1.

before tests could even start running. This is because after 4 years a new minor version of setproctitle was released a couple days ago
image

This PR fixes the setproctitle version that we install for tests to 1.1.10 which is the version that was being used prior to 11/24.

Note that serve:test_api still fails, but the tests are now running again on the windows build rather than failing during dependency installation.

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@amogkam amogkam changed the title [WIP] Attempt to fix windows build [CI] Fix windows build Nov 26, 2020
@amogkam amogkam requested a review from ericl November 26, 2020 18:04
@amogkam amogkam requested a review from simon-mo November 26, 2020 18:04
@simon-mo simon-mo merged commit e0573df into ray-project:master Nov 26, 2020
@acxz acxz mentioned this pull request Dec 17, 2020
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants