[CI] Fix windows build#12415
Merged
simon-mo merged 11 commits intoray-project:masterfrom Nov 26, 2020
Merged
Conversation
…nd correct the tests (ray-project#12141)" This reverts commit 4066056.
…ctions and correct the tests (ray-project#12141)"" This reverts commit bb27b87.
simon-mo
approved these changes
Nov 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our windows build was previously failing with
before tests could even start running. This is because after 4 years a new minor version of setproctitle was released a couple days ago

This PR fixes the setproctitle version that we install for tests to 1.1.10 which is the version that was being used prior to 11/24.
Note that serve:test_api still fails, but the tests are now running again on the windows build rather than failing during dependency installation.
Why are these changes needed?
Related issue number
Checks
scripts/format.shto lint the changes in this PR.