change hmset to hset on is start dashboard method since hmset was dep…#11632
Closed
tahentx wants to merge 1 commit intoray-project:masterfrom
Closed
change hmset to hset on is start dashboard method since hmset was dep…#11632tahentx wants to merge 1 commit intoray-project:masterfrom
tahentx wants to merge 1 commit intoray-project:masterfrom
Conversation
…racated in redis 4.0
edoakes
approved these changes
Oct 27, 2020
Collaborator
|
Thanks @tahentx! |
Contributor
|
@tahentx thank you for your contribution! Unfortunately, it seems like there's an issue, as CI is failing with errors like: Could you please take a look and ping me afterwards? Thanks! |
Author
|
Thanks @mfitton ! After some research, it seems like this same issue came up in this repo: rq/rq#1256 , and that an update was required with the redis server. I believe it might be the resolution here because the old function (hmset) took the same arguments in the same form as the new function (hset). And I didn't touch those. I look forward to your feedback. |
Member
|
Guys, FYI, there is a similar PR #11776. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…racated in redis 4.0
Why are these changes needed?
Related issue number
Checks
scripts/format.shto lint the changes in this PR.