[Docs] READmes for DockerHub#11350
Merged
simon-mo merged 12 commits intoray-project:masterfrom Oct 16, 2020
Merged
Conversation
Contributor
|
This doesn't setup the automatic push to dockerhub yet, right? just confirming |
Contributor
Author
|
Correct, the next step is for me to see how easy it is to add that into CI
…On Tue, Oct 13, 2020 at 9:30 AM Simon Mo ***@***.***> wrote:
This doesn't setup the automatic push to dockerhub yet, right? just
confirming
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#11350 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFC5KQWVJJ2SP55LSB7LORDSKR6DFANCNFSM4SNVFG2Q>
.
|
simon-mo
approved these changes
Oct 14, 2020
Contributor
simon-mo
left a comment
There was a problem hiding this comment.
LGTM but let's wait for @edoakes to take another pass. Two high level:
- Maybe we should undocument base-deps and ray-deps in ray-ml and ray regular user don't need to see it.
- Can we link the docker file for each image in their readme? that would be amazing for users.
Contributor
Author
|
Dropped the links to |
edoakes
approved these changes
Oct 16, 2020
Collaborator
edoakes
left a comment
There was a problem hiding this comment.
Looks good, just some small suggestions!
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Add DockerHub READMEs into GitHub.
Related issue number
Closes #10623
Checks
scripts/format.shto lint the changes in this PR.