[Java] Simplify Ray.init() by invoking ray start internally#10762
Merged
raulchen merged 52 commits intoray-project:masterfrom Dec 4, 2020
Merged
[Java] Simplify Ray.init() by invoking ray start internally#10762raulchen merged 52 commits intoray-project:masterfrom
Ray.init() by invoking ray start internally#10762raulchen merged 52 commits intoray-project:masterfrom
Conversation
Member
|
This is great. The duplicated code is easy to diverge and hard to maintain. My concern is that the user can't use |
raulchen
reviewed
Dec 2, 2020
java/runtime/src/main/java/io/ray/runtime/RayNativeRuntime.java
Outdated
Show resolved
Hide resolved
java/runtime/src/main/java/io/ray/runtime/runner/RunManager.java
Outdated
Show resolved
Hide resolved
chaokunyang
reviewed
Dec 3, 2020
.../java/streaming-runtime/src/main/java/io/ray/streaming/runtime/transfer/TransferHandler.java
Outdated
Show resolved
Hide resolved
raulchen
approved these changes
Dec 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
There are lots of duplicated logic copied from Python to Java when initializing Ray runtime. e.g.,
This PR updates the implementation of
Ray.init()to invokeray startandray stopinternally and try the best to leverage existing code in Python.pros
cons
pip install rayis required before when starting Ray on a single machine by a Java driver or Java unit test.Related issue number
Checks
scripts/format.shto lint the changes in this PR.