Skip to content

[hotfix] redis_password -> _redis_password#10672

Merged
richardliaw merged 1 commit intoray-project:masterfrom
wuisawesome:redis_password_hotfix
Sep 9, 2020
Merged

[hotfix] redis_password -> _redis_password#10672
richardliaw merged 1 commit intoray-project:masterfrom
wuisawesome:redis_password_hotfix

Conversation

@wuisawesome
Copy link
Copy Markdown
Contributor

Why are these changes needed?

This only fixes remaining code usages of ray.init(redis_password=...) -> ray.init(_redis_password=...).

We will need to comb through the docs and fix all those instances in a different PR.

Related issue number

Closes #10668

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/latest/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failure rates at https://ray-travis-tracker.herokuapp.com/.
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested (please justify below)

@wuisawesome wuisawesome added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Sep 9, 2020
@richardliaw richardliaw merged commit cd5b99e into ray-project:master Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests-ok The tagger certifies test failures are unrelated and assumes personal liability.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A lot of Ray commands fail in nightly build

2 participants