[RLlib] Add type annotations for agents/dqn#10626
Merged
sven1977 merged 4 commits intoray-project:masterfrom Sep 9, 2020
Merged
[RLlib] Add type annotations for agents/dqn#10626sven1977 merged 4 commits intoray-project:masterfrom
sven1977 merged 4 commits intoray-project:masterfrom
Conversation
sven1977
approved these changes
Sep 9, 2020
Contributor
sven1977
left a comment
There was a problem hiding this comment.
Looks great! Thanks @desktable !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Adding type annotations makes RLlib code easier to understand and develop on. Further context provided in #10115
Related issue number
Checks
scripts/format.shto lint the changes in this PR.