Revert "[Serialization] Update CloudPickle to 1.6.0 (#9694)"#10460
Merged
simon-mo merged 1 commit intoray-project:masterfrom Sep 1, 2020
Merged
Revert "[Serialization] Update CloudPickle to 1.6.0 (#9694)"#10460simon-mo merged 1 commit intoray-project:masterfrom
simon-mo merged 1 commit intoray-project:masterfrom
Conversation
This reverts commit f0c3910.
rkooo567
approved these changes
Sep 1, 2020
Contributor
|
Can you explain more about what and why this pr is blocking serve |
Contributor
Author
|
Sure. Serve is planning to use pydantic for its config options. #10389 But cloudpickle has trouble with Pydantic classes, I documented in the issue linked in the description. |
Contributor
Author
|
@rkooo567 another datapoint. The update also broke several rllib tests:
Master build: https://github.com/ray-project/ray/runs/1046975986 |
Contributor
|
@simon-mo Thanks for the info! I will add an issue to continue this task in the future. |
Contributor
|
Actually, I saw you made an issue. I will give P2 on the issue |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit f0c3910.
Why are these changes needed?
Serve is blocked by #10459, so I propose to revert the cloudpickle upgrade until cloudpickle can work with Pydantic well.
Related issue number
Checks
scripts/format.shto lint the changes in this PR.