Merged
Conversation
Contributor
Author
|
MBMPO Experiments here: https://github.com/ray-project/rl-experiments |
sven1977
requested changes
Aug 25, 2020
Contributor
sven1977
left a comment
There was a problem hiding this comment.
Great stuff. Just 2 comments, main one being: We need some regression learning test for this.
sven1977
reviewed
Aug 28, 2020
sven1977
approved these changes
Aug 28, 2020
Contributor
sven1977
left a comment
There was a problem hiding this comment.
Looks great! Could you remove the print of the loss, though, and pull master again? Then we can merge this.
Contributor
Author
|
@sven1977 Aight, updated to master and deleted comment. I think its good to go! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the Performance Bug for MBMPO; it was a combination of initial random exploration and bug in MBMPO vectorized environment
Why are these changes needed?
Related issue number
Checks
scripts/format.shto lint the changes in this PR.