-
Notifications
You must be signed in to change notification settings - Fork 7.4k
Closed
Labels
P2Important issue, but not time-criticalImportant issue, but not time-criticalbugSomething that is supposed to be working; but isn'tSomething that is supposed to be working; but isn'ttriageNeeds triage (eg: priority, bug/not-bug, and owning component)Needs triage (eg: priority, bug/not-bug, and owning component)
Description
[rllib]
What is the problem?
Framework setting passed to training script via config argument is ignored, because training script uses separate arguments for this field (--torch, --eager). If none of these args is passed to the script the framework is set to tf, regardless of options passed in --config argument.
Expected behavior
Script should use default value for framework field only if it is not already present in config dict (it can be passed as cmd argument or be loaded from file).
Reproduction (REQUIRED)
Run rllib train --run DQN --env CartPole-v0 --config "{\"framework\": \"tfe\"}" - script uses tf instead of tfe
- I have verified my script runs in a clean environment and reproduces the issue.
- I have verified the issue also occurs with the latest wheels.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
P2Important issue, but not time-criticalImportant issue, but not time-criticalbugSomething that is supposed to be working; but isn'tSomething that is supposed to be working; but isn'ttriageNeeds triage (eg: priority, bug/not-bug, and owning component)Needs triage (eg: priority, bug/not-bug, and owning component)