-
Notifications
You must be signed in to change notification settings - Fork 7.4k
Closed
Labels
P3Issue moderate in impact or severityIssue moderate in impact or severityenhancementRequest for new feature and/or capabilityRequest for new feature and/or capabilitypending-cleanupThis issue is pending cleanup. It will be removed in 2 weeks after being assigned.This issue is pending cleanup. It will be removed in 2 weeks after being assigned.
Description
This is a followup to this comment. I think you should not document calling actor.__ray_terminate__.remote() directly. I think Ray should provide ray.terminate_actor(actor) API, which then calls __ray_terminate__. This is more in-line with how Python has it. You do not call object.__delattr__(field) directly, you interact through API with it (del object[field]). The method exist to be able to be subclassed, but not called directly.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
P3Issue moderate in impact or severityIssue moderate in impact or severityenhancementRequest for new feature and/or capabilityRequest for new feature and/or capabilitypending-cleanupThis issue is pending cleanup. It will be removed in 2 weeks after being assigned.This issue is pending cleanup. It will be removed in 2 weeks after being assigned.