-
Notifications
You must be signed in to change notification settings - Fork 732
[Feature][RFC] RayCluster CRD: interface cleanup #368
Copy link
Copy link
Closed
Labels
P1Issue that should be fixed within a few weeksIssue that should be fixed within a few weeksenhancementNew feature or requestNew feature or request
Milestone
Description
Search before asking
- I had searched in the issues and found no similar feature requirement.
Description
Minimal configuration for RayCluster CRs should be as simple as possible. Some suggestions:
- Make rayStartParams optional. If specifying
{}is valid, not specifying the field at all should also be valid.- Most users shouldn't have to specify any rayStartParams at all.
- Consider always adding
--block. The current default behavior of adding a "sleep infinity" after ray start is unintuitive and probably incorrect.
- Make serviceType optional. Default to ClusterIP -- this is K8s's default and what most users would expect.
Use case
Make default configuration as simple and minimal as possible for standard use-cases.
Related issues
No response
Are you willing to submit a PR?
- Yes I am willing to submit a PR!
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
P1Issue that should be fixed within a few weeksIssue that should be fixed within a few weeksenhancementNew feature or requestNew feature or request