fix: don't interfere with repo package.json#43
Merged
DariuszPorowski merged 1 commit intoraven-actions:mainfrom Oct 7, 2025
allejo:fix/dont-mess-with-npm-project
Merged
fix: don't interfere with repo package.json#43DariuszPorowski merged 1 commit intoraven-actions:mainfrom allejo:fix/dont-mess-with-npm-project
DariuszPorowski merged 1 commit intoraven-actions:mainfrom
allejo:fix/dont-mess-with-npm-project
Conversation
Collaborator
|
@allejo good catch, thanks! Going to release this week new version. |
DariuszPorowski
approved these changes
Oct 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💌 Description
This action will do an
npm install @actions/tool-cache, by default in the current working directory. There is a configurableinputs.working-directory, but I haven't tested to see if using that will change the behavior I'm seeing.Regardless of the configurable working directory, running
npm install <package>in a JavaScript repository will modifypackage.json, its lockfile, and run lifecycle scripts. This can cause side effects because a GitHub action is unintentionally modifying the cloned code.🔗 Related issue
Fixes: N/A
📚 Type of change
✔️ Checklist
Code of Conductdocument.Contributingguide.