Skip to content

security: Update version pins to use SHAs instead#30

Merged
DariuszPorowski merged 1 commit intoraven-actions:mainfrom
Skipants:update-pinned-versions
May 29, 2025
Merged

security: Update version pins to use SHAs instead#30
DariuszPorowski merged 1 commit intoraven-actions:mainfrom
Skipants:update-pinned-versions

Conversation

@Skipants
Copy link
Contributor

💌 Description

Hello! I love the work you did on this action and want to include it in my company's CI. It's saving me a ton of time.

I have made an update on my fork to to harden the security of this action and to help mitigate some upstream supply chain risks.

I bet you've heard of the tj-actions supply chain attack but for posterity there's more info here: https://www.stepsecurity.io/blog/harden-runner-detection-tj-actions-changed-files-action-is-compromised

That attack is the main reason for me making this change here and to some of our other upstream github actions.

Let me know if there's anything that needs changing.

🏗️ Type of change

  • 📚 Examples/docs/tutorials
  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🚨 Security fix
  • ⬆️ Dependencies update

✅ Checklist

Spurred by the tj-actions supply chain attack, it is a good idea to harden actions by pinning to SHAs of custom github action commits instead of using their tags.

See https://www.stepsecurity.io/blog/harden-runner-detection-tj-actions-changed-files-action-is-compromised for details of the attack.
@Skipants Skipants requested a review from a team as a code owner May 28, 2025 19:09
Copy link
Collaborator

@DariuszPorowski DariuszPorowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@DariuszPorowski DariuszPorowski merged commit 7b7b099 into raven-actions:main May 29, 2025
5 checks passed
@Skipants Skipants deleted the update-pinned-versions branch May 29, 2025 19:17
@Skipants
Copy link
Contributor Author

@DariuszPorowski BTW in case you're interested since you manage so many of these -- I made a simple go executable to automatically update Github Action workflow files to use SHAs instead of tags/branches. It pulls the SHAs straight from Github itself: https://github.com/Skipants/update-action-pins

@DariuszPorowski
Copy link
Collaborator

@Skipants this is great! will take a look, thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants