Align TraditionalChinese Server_ActorCast with Global#38
Closed
MilkVio wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates TraditionalChinese.Server_ActorCast to match the Global layout.
The previous TraditionalChinese Server_ActorCast layout is not compatible with the current OverlayPlugin handling and can cause a silent exception when parsing ActorCastExtra.
More specifically, OverlayPlugin expects Rotation to be readable as UInt16 in ActorCastExtra, but the TraditionalChinese definition does not currently match the Global layout. After syncing this struct with Global locally, the corresponding log output appeared correctly again.
While comparing TraditionalChinese headers against Global, I noticed a few other structural differences as well, but I have not validated those yet, so this PR intentionally limits the change to Server_ActorCast.