Aggregate k-mer counts with --count-kmers in transform_anno#568
Merged
adamant-pwn merged 6 commits intomasterfrom Nov 21, 2025
Merged
Aggregate k-mer counts with --count-kmers in transform_anno#568adamant-pwn merged 6 commits intomasterfrom
adamant-pwn merged 6 commits intomasterfrom
Conversation
karasikov
reviewed
Nov 19, 2025
karasikov
reviewed
Nov 19, 2025
karasikov
requested changes
Nov 19, 2025
karasikov
reviewed
Nov 20, 2025
karasikov
reviewed
Nov 20, 2025
karasikov
reviewed
Nov 20, 2025
karasikov
reviewed
Nov 20, 2025
karasikov
reviewed
Nov 20, 2025
karasikov
requested changes
Nov 20, 2025
Member
karasikov
left a comment
There was a problem hiding this comment.
The code looks good, let's add some tests where we aggregate counts from multiple columns, and also edge cases
karasikov
approved these changes
Nov 21, 2025
Co-authored-by: Mikhail Karasikov <karasikov@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With a new test to verify correct filtering and aggregation.