Skip to content

make sure htslib is built for the same arch#534

Merged
karasikov merged 20 commits intomasterfrom
mk/rosetta
Oct 1, 2025
Merged

make sure htslib is built for the same arch#534
karasikov merged 20 commits intomasterfrom
mk/rosetta

Conversation

@karasikov
Copy link
Member

@karasikov karasikov commented Sep 30, 2025

  1. Fixes a tricky case when compiling on AppleSilicon (arm64) for x86_64 (happens, e.g., when cmake is x86_64).

All libraries are built for x86_64, but htslib checks compile for arm64 and fail linking against zlib compiled for x86_64.
Now we explicitly pass the target architecture for htslib.

  1. Also, now we always link against the static locally compiled htslib binary.

  2. Also improvements in the CI:

  • compile with more threads
  • correctly set the platform (previously all were Apple Silicon)
  • check x86_64 build on arm64

@karasikov karasikov mentioned this pull request Oct 1, 2025
@karasikov karasikov merged commit 24859b3 into master Oct 1, 2025
18 checks passed
@karasikov karasikov deleted the mk/rosetta branch October 1, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant