Merged
Conversation
…ffer is oppened per one get_rows call
Member
|
Please apply .clang-format or make it more or less consistent with the code style in the rest of the codebase. |
Collaborator
Author
|
Thanks for pointing this. I configured my environment to use .clang-format file and reformated my changes. If something is wrong let me know. |
hmusta
requested changes
Aug 14, 2022
Collaborator
hmusta
left a comment
There was a problem hiding this comment.
Here's my first batch of comments. I still need to look at annotation_converters.cpp
metagraph/src/annotation/binary_matrix/row_sparse_disk/row_sparse_disk.cpp
Outdated
Show resolved
Hide resolved
metagraph/src/annotation/binary_matrix/row_sparse_disk/row_sparse_disk.cpp
Outdated
Show resolved
Hide resolved
metagraph/src/annotation/binary_matrix/row_sparse_disk/row_sparse_disk.cpp
Outdated
Show resolved
Hide resolved
metagraph/src/annotation/binary_matrix/row_sparse_disk/row_sparse_disk.cpp
Outdated
Show resolved
Hide resolved
metagraph/src/annotation/binary_matrix/row_sparse_disk/row_sparse_disk.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Harun Mustafa <hmusta@users.noreply.github.com>
karasikov
requested changes
Sep 11, 2022
metagraph/src/annotation/binary_matrix/row_sparse_disk/row_sparse_disk.hpp
Outdated
Show resolved
Hide resolved
metagraph/src/annotation/binary_matrix/row_sparse_disk/row_sparse_disk.cpp
Outdated
Show resolved
Hide resolved
metagraph/src/annotation/binary_matrix/row_sparse_disk/row_sparse_disk.cpp
Outdated
Show resolved
Hide resolved
karasikov
requested changes
Sep 19, 2022
metagraph/src/annotation/binary_matrix/row_sparse_disk/row_sparse_disk.cpp
Outdated
Show resolved
Hide resolved
metagraph/src/annotation/binary_matrix/row_sparse_disk/row_sparse_disk.cpp
Outdated
Show resolved
Hide resolved
karasikov
reviewed
Sep 28, 2022
Co-authored-by: Mikhail Karasikov <karasikov@users.noreply.github.com>
…se_disk -> row_diff_disk)
… to parallelize transformation and do some code refactor
karasikov
reviewed
Jan 8, 2023
karasikov
reviewed
Jan 9, 2023
karasikov
approved these changes
Jan 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of row_sparse_disk and row_diff_sparse_disk annotations.
It seems I am overestimating memory requirements, which results in using less memory than specified with
--mem-cap-gb