Skip to content

fix #230: regression after fix for #197#231

Merged
silkentrance merged 1 commit intomasterfrom
gh-230
Jan 29, 2020
Merged

fix #230: regression after fix for #197#231
silkentrance merged 1 commit intomasterfrom
gh-230

Conversation

@silkentrance
Copy link
Copy Markdown
Collaborator

@silkentrance silkentrance commented Jan 29, 2020

  • must call either rimraf.sync or rmdirSync during garbage collection and not use a next parameter
  • remove rimraf wrappers, one can directly call the functions and the wrappers do not make any sense

…c or rmdirSync during garbage collection and not use a next parameter
@silkentrance
Copy link
Copy Markdown
Collaborator Author

The issue did go unnoticed since all exceptions will be ignored during garbage collection.
And maybe there is a missing test for dirsync and unsafeCleanup. will check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant