Skip to content

fix: fail early if there is no tmp dir specified #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
silkentrance merged 1 commit into from
Mar 20, 2019
Merged

fix: fail early if there is no tmp dir specified #177

silkentrance merged 1 commit into from
Mar 20, 2019

Conversation

@silkentrance
Copy link
Collaborator

@silkentrance silkentrance commented Oct 6, 2018 •
edited by raszi
Loading

Fixes #176.

This will cause _generateTmpName to fail early if both opts.dir and tmpDir are undefined.

@silkentrance
Copy link
Collaborator Author

silkentrance commented Oct 6, 2018

Still working on tests for this...

raszi
raszi requested changes Oct 8, 2018
View reviewed changes
Copy link
Owner

@raszi raszi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add tests.

@raszi raszi changed the title fix gh-176: fail early if there is no tmp dir specified fix: fail early if there is no tmp dir specified Oct 8, 2018
@silkentrance
Copy link
Collaborator Author

silkentrance commented Oct 31, 2018

@raszi thank you for the review. I will try to address these issues ASAP.

@silkentrance silkentrance force-pushed the gh-176 branch 3 times, most recently from b0ad81a to 71b00bf Compare March 13, 2019 21:58
@silkentrance
Copy link
Collaborator Author

silkentrance commented Mar 13, 2019

Please also add tests.

Missing tests have been added.

@silkentrance silkentrance requested a review from raszi March 16, 2019 14:15
@silkentrance
Copy link
Collaborator Author

silkentrance commented Mar 19, 2019

@raszi tests have been added.

@silkentrance
Copy link
Collaborator Author

silkentrance commented Mar 20, 2019

Merging now as all change requests have been met.

@silkentrance silkentrance merged commit 69ad512 into master Mar 20, 2019
@silkentrance silkentrance deleted the gh-176 branch March 20, 2019 19:52
This was referenced Mar 14, 2021
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raszi raszi Awaiting requested review from raszi

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Windows Temp file not working electron

3 participants

@silkentrance @raszi