Skip to content

fix(fileSync): must honor detachDescriptor and discardDescriptor options#149

Merged
raszi merged 1 commit intomasterfrom
gh-148
Aug 12, 2017
Merged

fix(fileSync): must honor detachDescriptor and discardDescriptor options#149
raszi merged 1 commit intomasterfrom
gh-148

Conversation

@silkentrance
Copy link
Copy Markdown
Collaborator

@silkentrance silkentrance commented Jul 15, 2017

fix #148

@silkentrance
Copy link
Copy Markdown
Collaborator Author

silkentrance commented Jul 19, 2017

@raszi I think that we can merge this one. However, it would require a new release on npm. I already bumped the version to 0.0.33. Reverted that to 0.0.32 as the latest on npmjs.com is 0.0.31.

@raszi raszi merged commit fb3801a into master Aug 12, 2017
@silkentrance silkentrance deleted the gh-148 branch August 16, 2017 19:42
@raszi raszi changed the title fileSync must honor detachDescriptor and discardDescriptor options fix: fileSync must honor detachDescriptor and discardDescriptor options Aug 29, 2018
@raszi raszi changed the title fix: fileSync must honor detachDescriptor and discardDescriptor options fix(fileSync): must honor detachDescriptor and discardDescriptor options Aug 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fileSync does not implement discardDescriptor nor detachDescriptor

2 participants