Conversation
raszi
reviewed
Apr 6, 2017
lib/tmp.js
Outdated
| const removeCallback = _prepareRemoveCallback(function _removeCallback(fdPath) { | ||
| try { | ||
| if (0 <= fdPath[0]) { | ||
| if (-1 != fdPath[0]) { |
Owner
There was a problem hiding this comment.
Is there any specific reason why you allow negative values as well except -1?
Collaborator
Author
There was a problem hiding this comment.
There was this other PR that sets the fd to -1.
Owner
There was a problem hiding this comment.
Right now the condition in the master branch looks like this:
if (0 <= fdPath[0])
Collaborator
Author
There was a problem hiding this comment.
Ah, I now see the problem. I will change that as soon as I find the time.
Collaborator
Author
Owner
|
Sure, yeah! I just fixed the small file descriptor issue but I did not have time to wait for the tests to finish on Travis. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #117
Add node 7 to travis build matrix
Bump version to 0.0.32