Merged
Conversation
exec() requires you to quote commands and arguments properly which is hard to do in a cross-platform way correctly. spawn() requires more work to handle output but avoids the need to quote commands correctly. On Windows, commands (including node.exe) generally are accessible via paths with spaces in them. This helps with raszi#109.
Creating symlinks requires elevated privileges on Windows. So skip that part of the test on Windows.
Creating symlinks requires elevated privileges on Windows. So skip that part of the test on Windows.
If you try to recreate a file too quickly after deleting it on Windows it will give you EPERM. This is why things like graceful-fs exist. Working around this in the tests by just not using the same name in both file-test.js and file-sync-test.js.
Necessary to support node-0.6.
Apparently the 'close' event is not available, so that complicates things.
|
This would be awesome to get merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Get tests running on Windows using various hacks and considerations for this non-unix platform.