fix: prefer kreadconfig6 with fallback to kreadconfig5#1599
Merged
tdewey-rpi merged 2 commits intoApr 23, 2026
Conversation
Previously hardcoded kreadconfig5, which fails on KDE Plasma 6. Now uses KDE_SESSION_VERSION env var to build the binary path dynamically (kreadconfig5 or kreadconfig6), avoiding ambiguity when both binaries are installed side by side.
lurch
reviewed
Apr 20, 2026
Contributor
Author
|
@lurch Updated in the latest commit, please take another look! |
Collaborator
Cool. I guess you might want to update the PR description? 😉 |
Contributor
Author
|
@lurch Done! |
Collaborator
|
Would you mind updating the PR title too? Thank you. |
Contributor
Author
|
@lurch Done ! Thanks |
tdewey-rpi
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously hardcoded kreadconfig5, which fails on KDE Plasma 6.
Now tries kreadconfig6 first, falls back to kreadconfig5 if not found.