fix(ImComboBox): use PlatformHelper for scroll direction in closed ComboBox#1534
Merged
tdewey-rpi merged 1 commit intoMar 4, 2026
Conversation
…mboBox The closed-state WheelHandler was using event.inverted directly to detect natural scrolling, but Qt doesn't reliably report the scroll direction on Windows. The popup WheelHandler already used PlatformHelper.isScrollInverted() which reads the actual OS setting (Windows registry). This inconsistency caused inverted scroll direction for ComboBox dropdowns on Windows. Align both handlers to use PlatformHelper.isScrollInverted() so the scroll direction is correct on all platforms. Closes raspberrypi#1532
f87c7a5 to
820f647
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PlatformHelper.isScrollInverted()instead ofevent.inverteddirectlyRoot Cause
ImComboBox.qmlhas twoWheelHandlerblocks:event.inverteddirectlyPlatformHelper.isScrollInverted(event.inverted)On Windows, Qt's
event.invertedflag doesn't reliably reflect the OS scroll direction setting.PlatformHelper.isScrollInverted()works around this by reading the actual value from the Windows registry (PrecisionTouchPad\ScrollDirection). On macOS/Linux, it passes throughevent.invertedunchanged — so this fix has no behavioral change on those platforms.Closes #1532