fix(ImFileDialog): allow typing/pasting full file paths in open mode#1530
Merged
tdewey-rpi merged 1 commit intoMar 3, 2026
Merged
Conversation
624907f to
5a4f7dd
Compare
The path field in open mode previously only supported folder navigation. When a user typed a complete file path (e.g. ~/Downloads/image.img) and pressed Enter, it was incorrectly treated as a directory path and failed silently. Add file-path detection via extension heuristic so that typed file paths are accepted directly, and enable the Open button when a file-like path is entered. Closes raspberrypi#1502
5a4f7dd to
f1f8deb
Compare
Collaborator
|
I'm essentially happy with this change. Thanks for the submission, @4RH1T3CT0R7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
~/Downloads/image.img) and pressed Enter, it was incorrectly treated as a directory path and failed silently.!isSaveDialog, so save mode is unaffected.Closes #1502