2.0.7: Remove legacy mountutils/drivelist, bugfixes#1513
Merged
Conversation
…erations - Deleted the mountutils dependency and its associated files, streamlining the project. - Updated disk unmount and eject operations in PlatformQuirks for Linux and macOS to handle device paths directly. - Enhanced error handling and logging for disk operations, improving reliability and user feedback. - Adjusted license and copyright information in relevant files to reflect the removal of mountutils.
…olete files - Updated include paths for the drivelist dependency from "dependencies/drivelist/src/drivelist.hpp" to "drivelist/drivelist.h" across multiple source files. - Deleted the entire drivelist dependency directory, including all associated files and tests, to streamline the project structure. - Introduced new platform-specific implementations for drive enumeration in macOS and Linux, enhancing compatibility and maintainability. - Adjusted CMake configurations to reflect the new file structure and ensure proper compilation.
…em drive checks - Removed the manual definition of DRIVELIST_ENABLE_TEST_API, now set via CMake compile definitions for better configuration management. - Updated system drive test to check for system mountpoints instead of displayability, aligning with the new filtering logic in DriveListModel.
… enhance CMake configuration - Introduced a new test file for PlatformQuirks, implementing unit tests for path transformations and device number parsing across different platforms (macOS, Windows, Linux). - Enhanced CMakeLists.txt to define platform-specific sources and libraries for the new platformquirks_test executable. - Updated platformquirks_windows.cpp to expose the parseDeviceNumber function for testing, improving test coverage and maintainability. - Added custom target for running platformquirks tests via CTest.
…ter redirects - Added functionality to track the effective URL after redirects in CurlFetcher, allowing for better debugging and user feedback. - Updated the `finished` signal to include the effective URL, ensuring the final URL is communicated after fetch completion. - Modified `onFetchComplete` and related methods to handle the new effective URL parameter, improving the accuracy of URL reporting. - Adjusted ImageWriter to reflect changes in the effective URL for top-level requests, enhancing security and transparency for users.
…numeration - Implemented error handling in DriveListModel to emit signals for enumeration errors, allowing the UI to display relevant messages. - Added a property to track the last enumeration error message, improving user experience during drive selection. - Updated StorageSelectionStep QML to show an error banner when drive enumeration fails, providing clear feedback to users. - Enhanced logging for drive enumeration failures to assist in debugging and user support.
…tModel - Updated comments for clarity, correcting "seperate" to "separate". - Changed the signature of rowCount to include a default parameter for better consistency with QAbstractListModel. - Enhanced signal-slot connection syntax for improved readability and modern C++ practices.
…atform quirks - Removed the logging of the WWAN flag from the network status change log for clarity. - Updated the log message to focus on essential network status indicators, improving readability and reducing noise in logs.
- Added .cache/clangd to .gitignore to prevent clangd cache files from being tracked. - Ensured test-cli-** entry is properly formatted with a newline for consistency.
- Updated ImageWriter to load local manifest files directly without confirmation, aligning with CLI behavior. - Improved URL handling in main.cpp to differentiate between local file URLs and other types, ensuring correct processing of local manifest files. - Enhanced user experience by streamlining the loading process for trusted local files.
…e thread management - Added checks to prevent multiple concurrent write operations, ensuring thread safety and avoiding potential crashes. - Enhanced cleanup of the write thread to handle cases where a thread may not have been properly terminated. - Updated progress watchdog initiation to start only after device authorization, preventing false stall detections during macOS authorization dialogs. - Implemented cancellation of running threads on error to prevent orphaned operations during new write attempts.
- Prevent re-entry during write operations and improve thread management. - Load local manifest files directly without confirmation and enhance URL handling. - Replace vendored drivelist/mountutils with platform-specific implementations for macOS, Linux, and Windows. - Enhance error handling and UI feedback during drive enumeration failures. - Simplify network status logging and update disk operations for macOS. - Add unit tests for platform-specific quirks and update CMake definitions. - Update .gitignore to include clangd cache files.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.