Thanks for the submission, @4RH1T3CT0R7 - I'm particularly impressed that you followed the pattern for screen reader support, and appear to have designed this carefully.

One thing we should consider, though: Users already had the ability to write an OS 'fresh' using the 'skip customisation' button. Do you have an opinion on whether that button is now effectively redundant?

It's not something that you've added @4RH1T3CT0R7 , but I've just noticed that our code has an awkward mix of "Customisation" / "Customization" spellings 😕 E.g. getSavedCustomisationSettings vs. imageSupportsCustomization
@tdewey-rpi Should we prefer one spelling in the code over the other, for consistency? (or am I just being too pedantic again?)

One thing we should consider, though: Users already had the ability to write an OS 'fresh' using the 'skip customisation' button. Do you have an opinion on whether that button is now effectively redundant?

IMHO those two buttons serve different purposes - the "skip customisation" button is still the only way to skip all the customisation questions, and ensure that no customisations are applied to the image? Whereas this new button is just "forget my previously-used answers".

One thing we should consider, though: Users already had the ability to write an OS 'fresh' using the 'skip customisation' button. Do you have an opinion on whether that button is now effectively redundant?

IMHO those two buttons serve different purposes - the "skip customisation" button is still the only way to skip all the customisation questions, and ensure that no customisations are applied to the image? Whereas this new button is just "forget my previously-used answers".

That's certainly how I saw it, but we don't have a metrics hook on the button, so I'm soliciting feedback from the author on if the alternative flow is clearer:

Before:

• Press 'skip' at any stage
• No explicit clear-everything button, clear stage-by-stage

After:

• Explicit clear-everything button
• Remove 'skip', to not customise clear-everything

@4RH1T3CT0R7 I've just noticed that the commits in this PR include:

• Handle overestimated extract sizes: switch to indeterminate progress for unexpected large writes and cap verification progress at 100%.
• Revert "Handle overestimated extract sizes: switch to indeterminate progress for unexpected large writes and cap verification progress at 100%."

Could you squash the PR down to a single commit please? Thank you.

@tdewey-rpi @lurch I agree with lurch's take here — the two buttons serve different purposes and should coexist. "Skip customisation" lets the user write an image with no customisations applied at all, while "Clear saved customisation" simply forgets previously saved answers, allowing the user to start fresh if they want to fill in new settings. Removing "Skip" would force users who don't want any customisation to manually clear everything, which is a worse experience. So I'd prefer to keep both buttons

@4RH1T3CT0R7 I've just noticed that the commits in this PR include:

• Handle overestimated extract sizes: switch to indeterminate progress for unexpected large writes and cap verification progress at 100%.
• Revert "Handle overestimated extract sizes: switch to indeterminate progress for unexpected large writes and cap verification progress at 100%."

Could you squash the PR down to a single commit please? Thank you.

done

Tested on macOS - a delightfully unobtrusive change.