Skip to content

feat(installer): Add windows installer dark mode support in rpi-imager.iss.in#1480

Merged
tdewey-rpi merged 1 commit into
raspberrypi:mainfrom
rc-chuah:feat/add-dark-mode-support-in-inno-setup-installer
Jan 26, 2026
Merged

feat(installer): Add windows installer dark mode support in rpi-imager.iss.in#1480
tdewey-rpi merged 1 commit into
raspberrypi:mainfrom
rc-chuah:feat/add-dark-mode-support-in-inno-setup-installer

Conversation

@rc-chuah

@rc-chuah rc-chuah commented Jan 25, 2026

Copy link
Copy Markdown
Contributor

Add windows installer dark mode support in rpi-imager.iss.in.

@lurch

lurch commented Jan 26, 2026

Copy link
Copy Markdown
Collaborator

Is there a risk that if we add dark-mode support to the Windows installer, people will also then expect Raspberry Pi Imager itself to offer a dark-mode? 🤔

@rc-chuah rc-chuah changed the title feat(installer): Add dark mode support in rpi-imager.iss.in feat(installer): Add windows installer dark mode support in rpi-imager.iss.in Jan 26, 2026
@rc-chuah

rc-chuah commented Jan 26, 2026

Copy link
Copy Markdown
Contributor Author

Is there a risk that if we add dark-mode support to the Windows installer, people will also then expect Raspberry Pi Imager itself to offer a dark-mode? 🤔

That’s a really good consideration! In this PR, the dark‑mode support is purely about aligning with Windows installer conventions, so it doesn’t imply theming changes inside Raspberry Pi Imager itself. If people do ask about dark‑mode in Raspberry Pi Imager after seeing this, we can clarify that it’s a separate feature request and decide based on demand. I can also add a note in the PR description to make that distinction clear.

@tdewey-rpi

Copy link
Copy Markdown
Collaborator

Thanks for the submission @rc-chuah

Looks good to me, and good catch!

@tdewey-rpi tdewey-rpi merged commit 8da2bec into raspberrypi:main Jan 26, 2026
@rc-chuah

Copy link
Copy Markdown
Contributor Author

Thanks for the submission @rc-chuah

Looks good to me, and good catch!

You're welcome 😊.

@rc-chuah rc-chuah deleted the feat/add-dark-mode-support-in-inno-setup-installer branch January 27, 2026 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants