fix(asyncio): Fix behaviour with misbehaving storage devices#1453
Merged
Conversation
- Added new recovery events to the ImagingCycle class, including 'hardTimeout'. - Implemented print_recovery_events function to summarize recovery actions during writes. - Updated print_cycles and print_pipeline_analysis functions to include recovery event types. - Introduced WriteProgressWatchdog to monitor write progress and detect stalls, with recovery strategies for async I/O. - Enhanced file operations across platforms to support queue depth reduction and sync fallback mechanisms. - Improved memory management and timeout utilities for better handling of stalled operations. This update aims to improve the robustness of the write process by providing better diagnostics and recovery options for slow or unresponsive devices.
…ing and thread safety - Added handling for kTimeout error in ConvertFileError function to enhance error reporting. - Changed _cancelled member in DownloadThread to std::atomic<bool> for safe access across threads. - Updated runWithTimeout function to include a type trait check, ensuring compatibility with non-void return types.
This was
linked to
issues
Jan 14, 2026
…ites across platforms - Updated the WaitForPendingWrites function in Linux, macOS, and Windows implementations to unify timeout logic. - Introduced a 5-minute emergency timeout as a fallback for stalled operations, enhancing robustness. - Adjusted logging to provide clearer information during emergency timeout scenarios. - Removed adaptive queue depth reduction logic to simplify the handling of pending writes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.