Skip to content

Add Cluster Tag#128

Merged
johallar merged 1 commit into
mainfrom
add_cluster_tag
Nov 20, 2025
Merged

Add Cluster Tag#128
johallar merged 1 commit into
mainfrom
add_cluster_tag

Conversation

@johallar

Copy link
Copy Markdown
Contributor

Adds cluster tag config to our velox-testing start scripts for java, cpu, gpu.

Sister PR to prestodb/presto#26485, which will display this tag in the UI so we can easily identify which type of cluster we have created.

@simoneves simoneves left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, but what reads this? Is it related to your other Presto PR?

@johallar

Copy link
Copy Markdown
Contributor Author

Sister PR to prestodb/presto#26485, which will display this tag in the UI so we can easily identify which type of cluster we have created.

The PR that uses this flag and UI changes to display it linked in the PR description 😄

@simoneves

Copy link
Copy Markdown
Contributor

The PR that uses this flag and UI changes to display it linked in the PR description 😄

Ugh. Sorry. My brain was fuzz yesterday.

@simoneves simoneves left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simoneves

Copy link
Copy Markdown
Contributor

@johallar I guess my remaining confusion is that the name cluster-tag seems a bit generic, but it seems that that is the intention from their end.

@johallar

Copy link
Copy Markdown
Contributor Author

@johallar I guess my remaining confusion is that the name cluster-tag seems a bit generic, but it seems that that is the intention from their end.

Yeah, for this first version the idea was to keep it very generic and user defined. Second steps would default it in a smart way based on the cluster configuration. Still a little unclear myself how that defaulting will work

@johallar johallar merged commit b49c408 into main Nov 20, 2025
@johallar johallar deleted the add_cluster_tag branch November 20, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants