Support both ucx:// and ucxx:// prefixes in distributed-ucxx#504
Support both ucx:// and ucxx:// prefixes in distributed-ucxx#504rapids-bot[bot] merged 5 commits intorapidsai:branch-0.46from
ucx:// and ucxx:// prefixes in distributed-ucxx#504Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
|
/ok to test |
|
/ok to test |
| UCXXBackend, | ||
| UCXXBackendLegacyPrefix, | ||
| UCXXConnector, | ||
| UCXXListener, | ||
| ) # noqa: F401 |
There was a problem hiding this comment.
Consider adding a __all__ = ["UCXXBackend", ...], then you don't need noqa: F401
There was a problem hiding this comment.
This is not meant to be a public module, we need UCXXBackend/UCXXBackendLegacyPrefix to define them in pyproject.yaml, thus we don't want to have __all__ here. I think we can remove UCXXConnector and UCXXListener here, but because they're used in rapids-dask-dependency at the moment I won't do it now, so added a TODO in 7bb45e2, and will submit a draft PR to avoid missing this once this is merged.
There was a problem hiding this comment.
Opened #505 to revert those changes, but that cannot be done until we can remove direct usage of distributed-ucxx from rapids-dask-dependency.
|
Thanks Kyle and Mads for the reviews! |
|
/merge |
Now that Distributed deprecated
ucx://in dask/distributed#9105, we should now ensuredistributed-ucxxregisters both backends. This is currently handled by rapids-dask-dependency, but it will ultimately be removed from there when everything is in place.