This repository was archived by the owner on Sep 18, 2025. It is now read-only.
Update UCP configuration validation tests for UCX >= 1.12#804
Merged
pentschev merged 1 commit intorapidsai:branch-0.23from Nov 2, 2021
Merged
Conversation
Starting from UCX 1.12, it's not possible to validate non-UCP configuration options, update tests accordingly.
quasiben
approved these changes
Nov 1, 2021
Member
|
We can merge when tests pass |
Member
|
@gpucibot rerun tests |
Member
|
@gpucibot merge |
Member
Author
|
Thanks @quasiben and @jakirkham for reviews! |
Member
|
Thanks Peter for the update! |
This was referenced Nov 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting from UCX 1.12, it's not possible to validate non-UCP configuration options, update tests accordingly.
See openucx/ucx#7519 .