Skip to content

Fix failing tracking test#929

Merged
rapids-bot[bot] merged 2 commits intorapidsai:branch-22.02from
harrism:fix-tracking-test
Dec 6, 2021
Merged

Fix failing tracking test#929
rapids-bot[bot] merged 2 commits intorapidsai:branch-22.02from
harrism:fix-tracking-test

Conversation

@harrism
Copy link
Member

@harrism harrism commented Dec 3, 2021

Fixes #928.

#920 introduced a new test for the tracking_resource_adaptor::log_outstanding_allocations, but that function only logs when SPDLOG_ACTIVE_LEVEL <= SPDLOG_LEVEL_DEBUG, so the test needs to be gated on that condition as well.

@harrism harrism requested a review from a team as a code owner December 3, 2021 01:40
@harrism harrism requested review from cwharris and rongou December 3, 2021 01:40
@github-actions github-actions bot added the cpp Pertains to C++ code label Dec 3, 2021
@harrism harrism self-assigned this Dec 3, 2021
@harrism harrism added bug Something isn't working non-breaking Non-breaking change tests Related to unit tests labels Dec 3, 2021
@harrism
Copy link
Member Author

harrism commented Dec 6, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit bd5aa5d into rapidsai:branch-22.02 Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working cpp Pertains to C++ code non-breaking Non-breaking change tests Related to unit tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] TRACKING_TEST only works with RMM_LOGGING_LEVEL=DEBUG

4 participants