Skip to content

Use spdlog/fmt/ostr.h as it supports external fmt library#907

Merged
rapids-bot[bot] merged 1 commit intorapidsai:branch-21.12from
robertmaynard:bug/support_external_fmt_to_spdlog
Nov 4, 2021
Merged

Use spdlog/fmt/ostr.h as it supports external fmt library#907
rapids-bot[bot] merged 1 commit intorapidsai:branch-21.12from
robertmaynard:bug/support_external_fmt_to_spdlog

Conversation

@robertmaynard
Copy link
Contributor

Fixes #904

@robertmaynard robertmaynard added bug Something isn't working 3 - Ready for review Ready for review by team non-breaking Non-breaking change labels Nov 4, 2021
@robertmaynard robertmaynard requested a review from a team as a code owner November 4, 2021 13:47
@github-actions github-actions bot added the cpp Pertains to C++ code label Nov 4, 2021
@robertmaynard
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 11be49c into rapidsai:branch-21.12 Nov 4, 2021
@robertmaynard robertmaynard deleted the bug/support_external_fmt_to_spdlog branch November 4, 2021 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 - Ready for review Ready for review by team bug Something isn't working cpp Pertains to C++ code non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Cannot be built in an environment where fmt and spdlog are installed independently.

3 participants