Parameterize exception type caught by failure_callback_resource_adaptor#898
Merged
rapids-bot[bot] merged 7 commits intorapidsai:branch-21.12from Nov 9, 2021
Conversation
rongou
approved these changes
Oct 27, 2021
jrhemstad
reviewed
Oct 27, 2021
madsbk
approved these changes
Oct 27, 2021
jrhemstad
reviewed
Oct 27, 2021
jrhemstad
reviewed
Oct 27, 2021
jrhemstad
reviewed
Oct 27, 2021
jrhemstad
reviewed
Oct 27, 2021
Co-authored-by: Jake Hemstad <jhemstad@nvidia.com>
Member
|
rerun tests |
1 similar comment
Member
Author
|
rerun tests |
jrhemstad
approved these changes
Nov 9, 2021
Member
Author
|
@gpucibot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#892 added
failure_callback_resource_adaptorwhich provides the ability to respond to memory allocation failures. However, it was hard-coded to catch (and rethrow)std::bad_allocexceptions. This PR makes the type of exception the adaptor catches a template parameter, to provide greater flexibility. The default exception type is nowrmm::out_of_memorysince we expect this to be the common use case.Also a few changes to fix clang-tidy warnings.