[REVIEW] Align memory resource allocation sizes to 8-byte#165
Merged
jrhemstad merged 4 commits intorapidsai:branch-0.11from Oct 22, 2019
Merged
[REVIEW] Align memory resource allocation sizes to 8-byte#165jrhemstad merged 4 commits intorapidsai:branch-0.11from
jrhemstad merged 4 commits intorapidsai:branch-0.11from
Conversation
harrism
previously requested changes
Oct 22, 2019
Member
harrism
left a comment
There was a problem hiding this comment.
Just one namespace suggestion. Also need the changelog.
jrhemstad
requested changes
Oct 22, 2019
| /** | ||
| * Align up to a power of 2, align_bytes is expected to be a nonzero power of 2 | ||
| */ | ||
| inline std::size_t align_up(std::size_t v, std::size_t align_bytes) noexcept |
Contributor
There was a problem hiding this comment.
This should be documented consistent with https://github.com/rapidsai/cudf/blob/branch-0.11/cpp/src/examples/documentation_example.cpp
Contributor
Author
There was a problem hiding this comment.
Updated. Couldn't find the eyeroll emoji in in github.
jrhemstad
approved these changes
Oct 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align size of memory allocations to 8 bytes.