zarr-python 3.0.7 compatibility#699
Merged
rapids-bot[bot] merged 2 commits intorapidsai:branch-25.06from Apr 22, 2025
Merged
Conversation
|
|
||
|
|
||
| @functools.cache | ||
| def ZARR_3_0_7(): |
Contributor
There was a problem hiding this comment.
Nit:
Suggested change
| def ZARR_3_0_7(): | |
| def _is_ge_zarr_3_0_7(): |
kingcrimsontianyu
approved these changes
Apr 22, 2025
Contributor
kingcrimsontianyu
left a comment
There was a problem hiding this comment.
Thanks for the quick fix! Only left a minor suggestion.
Contributor
Author
|
/merge |
quasiben
approved these changes
Apr 22, 2025
Member
|
Thanks Tom and everyone who reviewed! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds compatibility for zarr-python 3.0.7, which changed the dtype for representing bytes in zarr-developers/zarr-python#2738.