Skip to content

Make Dask CUDA work with the new WorkerMemoryManager abstraction#870

Merged
rapids-bot[bot] merged 10 commits intorapidsai:branch-22.04from
shwina:worker-memory-manager-fixes
Mar 21, 2022
Merged

Make Dask CUDA work with the new WorkerMemoryManager abstraction#870
rapids-bot[bot] merged 10 commits intorapidsai:branch-22.04from
shwina:worker-memory-manager-fixes

Conversation

@shwina
Copy link
Contributor

@shwina shwina commented Mar 9, 2022

This PR updates dask-cuda to work with the new WorkerMemoryManager abstraction being introduced in dask/distributed#5904. Once both PRs are merged, and pending the resolution of https://github.com/dask/distributed/pull/5904/files#r822084806, dask-cuda CI should be unblocked.

@shwina shwina requested a review from a team as a code owner March 9, 2022 14:27
@github-actions github-actions bot added the python python code needed label Mar 9, 2022
w.memory_target_fraction = 1
await w.memory_monitor()
w.memory_manager.memory_limit = memory - 10 ** 8
w.memory_manager.memory_target_fraction = 1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work: dask/distributed#5367

@crusaderky
Copy link

requirements.txt mentions distributed>=2021.11.1; however this PR breaks backwards compatibility with <2022.03.1 (unreleased).

@jakirkham
Copy link
Member

rerun tests

1 similar comment
@jakirkham
Copy link
Member

rerun tests

@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2022

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.04@8200f2d). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-22.04     #870   +/-   ##
===============================================
  Coverage                ?   89.49%           
===============================================
  Files                   ?       16           
  Lines                   ?     2094           
  Branches                ?        0           
===============================================
  Hits                    ?     1874           
  Misses                  ?      220           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8200f2d...40e150d. Read the comment docs.

@jakirkham
Copy link
Member

rerun tests

@jakirkham jakirkham added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 19, 2022
@jakirkham
Copy link
Member

rerun tests

@pentschev
Copy link
Member

rerun tests

Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests passing now, thanks @shwina for the work here!

@pentschev
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 381ff6d into rapidsai:branch-22.04 Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python python code needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants