Drop test setting UCX global options via Dask config#738
Merged
rapids-bot[bot] merged 1 commit intorapidsai:branch-21.10from Sep 24, 2021
Merged
Conversation
Support for setting UCX global options was dropped in dask/distributed#4850, as the conflict of Dask configs and UCX configs can be dangerous since both used to live in the same namespace. Setting global UCX options can still be done via environment variables, such as `UCX_*`, and is the preferred method now.
Member
Author
|
Thanks for another fast review @madsbk ! |
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #738 +/- ##
================================================
+ Coverage 87.63% 89.18% +1.54%
================================================
Files 15 15
Lines 1658 1904 +246
================================================
+ Hits 1453 1698 +245
- Misses 205 206 +1
Continue to review full report at Codecov.
|
Member
Author
|
@gpucibot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for setting UCX global options was dropped in
dask/distributed#4850, as the conflict of Dask
configs and UCX configs can be dangerous since both used to live in the
same namespace. Setting global UCX options can still be done via
environment variables, such as
UCX_*, and is the preferred method now.Fixes #627