Replace weight by safe_sizeof#584
Merged
rapids-bot[bot] merged 3 commits intorapidsai:branch-0.20from Apr 21, 2021
Merged
Conversation
quasiben
approved these changes
Apr 20, 2021
Member
Author
|
rerun tests |
Member
Author
|
It seems that there are other issues in Distributed: dask/distributed@d5fc324#r49759517 . I'll retarget this to 0.20 and pin Distributed 2021.04.0 in 0.19 just as dask-cudf does. |
Member
|
Thanks for tracking these issues down @pentschev. xref-ing dask/distributed#4723 which adds |
Member
Author
|
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-0.20 #584 +/- ##
==============================================
Coverage ? 60.41%
==============================================
Files ? 22
Lines ? 2650
Branches ? 0
==============================================
Hits ? 1601
Misses ? 1049
Partials ? 0 Continue to review full report at Codecov.
|
Member
Author
|
@gpucibot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for changes in dask/distributed#4651